updated deprecated cryptiles #751
Merged
+58
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgaeddert
reviewed
May 13, 2020
There was a problem hiding this comment.
Looks safe to me, there seems to have been very little change between v4.1.3 we had in yarn.lock and v4.2.1.
@guzzijones I believe you missed all the refs to "cryptiles": "4.1.3", ex. apps/st2-actions/package.json
|
@bgaeddert What do you mean by your comment to @guzzijones ? Is there a change needed? |
bgaeddert
previously requested changes
May 14, 2020
There was a problem hiding this comment.
@guzzijones I believe you missed all the refs to "cryptiles": "4.1.3", ex. apps/st2-actions/package.json
|
@guzzijones can this be closed since you have another PR with these changes |
|
I updated the missing apps. I also noticed that. |
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.